Re: [Qemu-block] [PATCH v4 2/6] replication: add shared-disk and shared-disk-id options

[Hailiang Zhang]

On 2017/5/12 3:08, Stefan Hajnoczi wrote:
> On Wed, Apr 12, 2017 at 10:05:17PM +0800, zhanghailiang wrote:
> > We use these two options to identify which disk is
> > shared
> >
> > Signed-off-by: zhanghailiang <address@hidden>
> > Signed-off-by: Wen Congyang <address@hidden>
> > Signed-off-by: Zhang Chen <address@hidden>
> > ---
> > v4:
> > - Add proper comment for primary_disk (Stefan)
> > v2:
> > - Move g_free(s->shared_disk_id) to the common fail process place (Stefan)
> > - Fix comments for these two options
> > ---
> >   block/replication.c  | 43 +++++++++++++++++++++++++++++++++++++++++--
> >   qapi/block-core.json | 10 +++++++++-
> >   2 files changed, 50 insertions(+), 3 deletions(-)
> Aside from the ongoing discussion about this patch...
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>

Thanks,  I'll fix the related problems found by changlong.