[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] qemu-iotests: Test streaming with missing job I
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH] qemu-iotests: Test streaming with missing job ID |
|
Date: |
Mon, 15 May 2017 15:20:18 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 15 May 2017 03:05:00 PM CEST, Kevin Wolf wrote:
>> Mmm... but does that trigger the bug?
>>
>> The bug happens if the user tries to create a stream job on a BDS that:
>>
>> a) exists
>> b) is not the active node (i.e. needs reopening in read-write mode)
>> c) its node name is not valid for a block job (e.g. it contains a '#')
>
> I don't think c) is necessary, block jobs that are owned by a BDS
> identified by a node name always require an explicit job ID.
It defaults to bdrv_get_device_name() if the job ID is not set, but in
your case there's indeed none, so
Reviewed-by: Alberto Garcia <address@hidden>
Berto