[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img c
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert |
Date: |
Mon, 22 May 2017 16:17:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/22/2017 04:11 PM, Hervé Poussineau wrote:
> - bs->total_sectors is the number of sectors of the whole disk
> - s->sector_count is the number of sectors of the FAT partition
>
> This fixes the following assert in qemu-img map:
> qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed.
>
> This also fixes an infinite loop in qemu-img convert.
>
> Fixes: 4480e0f924a42e1db8b8cfcac4d0634dd1bb27a0
> Fixes: https://bugs.launchpad.net/qemu/+bug/1599539
> Signed-off-by: Hervé Poussineau <address@hidden>
> ---
> block/vvfat.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
I gave Reviewed-by: on version 1, and suggested that this be cc'd to
qemu-stable:
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg03622.html
It helps to add that into the commit message for v2, to make it clear
that you haven't changed anything in this commit since that review.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir, (continued)
- [Qemu-block] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert, Hervé Poussineau, 2017/05/22
- Re: [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert,
Eric Blake <=
- [Qemu-block] [PATCH v2 07/13] vvfat: always create . and .. entries at first and in that order, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 03/13] vvfat: fix typos, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 04/13] vvfat: rename useless enumeration values, Hervé Poussineau, 2017/05/22
- [Qemu-block] [PATCH v2 02/13] vvfat: replace tabs by 8 spaces, Hervé Poussineau, 2017/05/22
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode, no-reply, 2017/05/22