Re: [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled reques

qemu-block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled reques

From:	Alberto Garcia
Subject:	Re: [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex
Date:	Mon, 29 May 2017 16:24:37 +0200
User-agent:	Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Thu 25 May 2017 06:32:16 PM CEST, Paolo Bonzini wrote:
> Another possibility is to use tg->lock, which we're holding anyway in
> both schedule_next_request and throttle_group_co_io_limits_intercept.
> This would require open-coding the CoQueue however, so I've chosen this
> alternative.
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Alberto Garcia <address@hidden>

Berto

[Prev in Thread]

Current Thread

[Next in Thread]

[Qemu-block] [PATCH v3 00/18] Block layer thread safety, part 1, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 04/18] block: access serialising_in_flight with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 03/18] block: access io_limits_disabled with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 06/18] block: access io_plugged with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 01/18] block: access copy_on_read with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 02/18] block: access quiesce_counter with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 05/18] block: access wakeup with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 07/18] throttle-groups: only start one coroutine from drained_begin, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 08/18] throttle-groups: do not use qemu_co_enter_next, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex, Paolo Bonzini, 2017/05/25
  - Re: [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex, Alberto Garcia <=
- [Qemu-block] [PATCH 10/18] util: add stats64 module, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 11/18] block: use Stat64 for wr_highest_offset, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 12/18] block: access write_gen with atomics, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 13/18] block: protect tracked_requests and flush_queue with reqs_lock, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 14/18] block: introduce dirty_bitmap_mutex, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 15/18] migration/block: reset dirty bitmap before reading, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 17/18] block: introduce block_account_one_io, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 16/18] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 18/18] block: make accounting thread-safe, Paolo Bonzini, 2017/05/25
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 00/18] Block layer thread safety, part 1, no-reply, 2017/05/25

Prev by Date: Re: [Qemu-block] [PATCH v7 20/20] docs: document encryption options for qcow, qcow2 and luks
Next by Date: [Qemu-block] [PULL 00/15] Block layer patches
Previous by thread: [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex
Next by thread: [Qemu-block] [PATCH 10/18] util: add stats64 module
Index(es):
- Date
- Thread