[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 28/29] qed: Use a coroutine for need_check_timer
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH 28/29] qed: Use a coroutine for need_check_timer |
Date: |
Wed, 31 May 2017 13:56:11 +0100 |
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Fri, May 26, 2017 at 10:22:09PM +0200, Kevin Wolf wrote:
> This fixes the last place where we degraded from AIO to actual blocking
> synchronous I/O requests. Putting it into a coroutine means that instead
> of blocking, the coroutine simply yields while doing I/O.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qed.c | 33 +++++++++++++++++----------------
> 1 file changed, 17 insertions(+), 16 deletions(-)
>
> diff --git a/block/qed.c b/block/qed.c
> index d3f7d0c..20e81a0 100644
> --- a/block/qed.c
> +++ b/block/qed.c
> @@ -264,11 +264,23 @@ static void
> qed_unplug_allocating_write_reqs(BDRVQEDState *s)
> qemu_co_enter_next(&s->allocating_write_reqs);
> }
>
> -static void qed_clear_need_check(void *opaque, int ret)
> +static void qed_need_check_timer_entry(void *opaque)
Missing coroutine_fn.
signature.asc
Description: PGP signature
- Re: [Qemu-block] [Qemu-devel] [PATCH 23/29] qed: Remove ret argument from qed_aio_next_io(), (continued)
- [Qemu-block] [PATCH 22/29] qed: Add return value to qed_aio_read/write_data(), Kevin Wolf, 2017/05/26
- [Qemu-block] [PATCH 24/29] qed: Remove recursion in qed_aio_next_io(), Kevin Wolf, 2017/05/26
- [Qemu-block] [PATCH 25/29] qed: Implement .bdrv_co_readv/writev, Kevin Wolf, 2017/05/26
- [Qemu-block] [PATCH 27/29] qed: Simplify request handling, Kevin Wolf, 2017/05/26
- [Qemu-block] [PATCH 28/29] qed: Use a coroutine for need_check_timer, Kevin Wolf, 2017/05/26
- Re: [Qemu-block] [PATCH 28/29] qed: Use a coroutine for need_check_timer,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH 26/29] qed: Use CoQueue for serialising allocations, Kevin Wolf, 2017/05/26
- [Qemu-block] [PATCH 29/29] block: Remove bdrv_aio_readv/writev_flush(), Kevin Wolf, 2017/05/26
- Re: [Qemu-block] [PATCH 00/29] qed: Convert to coroutines, Paolo Bonzini, 2017/05/29