[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 4/4] qemu-iotests: Block migration test
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3 4/4] qemu-iotests: Block migration test |
|
Date: |
Wed, 31 May 2017 12:03:15 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/31/2017 04:52 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> tests/qemu-iotests/183 | 140
> +++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/183.out | 46 +++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 187 insertions(+)
> create mode 100755 tests/qemu-iotests/183
> create mode 100644 tests/qemu-iotests/183.out
> +qemu_comm_method="qmp"
> +
> +_launch_qemu \
> + -drive file="${TEST_IMG}",cache=${CACHEMODE},driver=$IMGFMT,id=disk
Inconsistent use of ${CACHEMODE} vs. $IMGFMT (I prefer the version with
less typing, but others prefer always using ${}). In both _launch_qemu
lines. Up to you if you want to tweak it, but either way,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature