[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 1/8] block: Fix anonymous BBs in blk_root_inactivate(
From: |
Kevin Wolf |
Subject: |
[Qemu-block] [PULL 1/8] block: Fix anonymous BBs in blk_root_inactivate() |
Date: |
Wed, 7 Jun 2017 19:50:12 +0200 |
blk->name isn't an array, but a pointer that can be NULL. Checking for
an anonymous BB must involve a NULL check first, otherwise we get
crashes.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
---
block/block-backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index f3a6008..7d7f369 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -168,7 +168,7 @@ static int blk_root_inactivate(BdrvChild *child)
* this point because the VM is stopped) and unattached monitor-owned
* BlockBackends. If there is still any other user like a block job, then
* we simply can't inactivate the image. */
- if (!blk->dev && !blk->name[0]) {
+ if (!blk->dev && !blk_name(blk)[0]) {
return -EPERM;
}
--
1.8.3.1
- [Qemu-block] [PULL 0/8] Block layer patches, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 1/8] block: Fix anonymous BBs in blk_root_inactivate(),
Kevin Wolf <=
- [Qemu-block] [PULL 2/8] migration: Inactivate images after .save_live_complete_precopy(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 3/8] migration/block: Clean up BBs in block_save_complete(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 4/8] qemu-iotests: Block migration test, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 5/8] commit: Fix use after free in completion, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 7/8] block/qcow.c: Fix memory leak in qcow_create(), Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 6/8] qemu-iotests: Test automatic commit job cancel on hot unplug, Kevin Wolf, 2017/06/07
- [Qemu-block] [PULL 8/8] block: fix external snapshot abort permission error, Kevin Wolf, 2017/06/07
- Re: [Qemu-block] [Qemu-devel] [PULL 0/8] Block layer patches, Peter Maydell, 2017/06/12