[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/5] block: Don't try to set *errp directly
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 2/5] block: Don't try to set *errp directly |
|
Date: |
Thu, 08 Jun 2017 17:04:08 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 08 Jun 2017 03:39:03 PM CEST, Eduardo Habkost wrote:
> Assigning directly to *errp is not valid, as errp may be NULL,
> &error_fatal, or &error_abort. Use error_propagate() instead.
Well, the NULL case was already handled by the code, but &error_fatal
and &error_abort certainly not.
> With this, there's no need to check if errp is NULL anymore, as
> error_propagate() and error_prepend() are able to handle that.
>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: address@hidden
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Alberto Garcia <address@hidden>
Berto