[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings |
Date: |
Tue, 13 Jun 2017 23:05:18 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Tue 13 Jun 2017 07:20:04 PM CEST, Max Reitz <address@hidden> wrote:
> blkdebug and blkverify use snprintf() to generate a filename; however,
> that may not fit into the target buffer (BDS.exact_filename). If so,
> they generate a truncated and thus pretty much unusable filename. In
> this case it's better to just not generate a filename at all (until we
> have better infrastructure which is not bound by a static buffer size).
>
> Also, gcc 7 warns about these snprintf() instances and these patches fix
> these warnings. There is another one in hw/usb/bus.c which is not
> addressed by this series.
>
> Max Reitz (2):
> blkdebug: Catch bs->exact_filename overflow
> blkverify: Catch bs->exact_filename overflow
Reviewed-by: Alberto Garcia <address@hidden>
Berto
- [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings, Max Reitz, 2017/06/13
- [Qemu-block] [PATCH 1/2] blkdebug: Catch bs->exact_filename overflow, Max Reitz, 2017/06/13
- [Qemu-block] [PATCH 2/2] blkverify: Catch bs->exact_filename overflow, Max Reitz, 2017/06/13
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/2] block: Fix gcc 7 warnings, no-reply, 2017/06/13
- Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings,
Alberto Garcia <=
- Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings, Stefan Hajnoczi, 2017/06/15
- Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings, Max Reitz, 2017/06/16