Re: [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings

[Stefan Hajnoczi]

On Tue, Jun 13, 2017 at 07:20:04PM +0200, Max Reitz wrote:
> blkdebug and blkverify use snprintf() to generate a filename; however,
> that may not fit into the target buffer (BDS.exact_filename). If so,
> they generate a truncated and thus pretty much unusable filename. In
> this case it's better to just not generate a filename at all (until we
> have better infrastructure which is not bound by a static buffer size).
> 
> Also, gcc 7 warns about these snprintf() instances and these patches fix
> these warnings. There is another one in hw/usb/bus.c which is not
> addressed by this series.
> 
> Max Reitz (2):
>   blkdebug: Catch bs->exact_filename overflow
>   blkverify: Catch bs->exact_filename overflow
> 
>  block/blkdebug.c  | 10 +++++++---
>  block/blkverify.c | 12 ++++++++----
>  2 files changed, 15 insertions(+), 7 deletions(-)
> 
> -- 
> 2.9.4
> 
> 

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature