[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_pr
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare() |
|
Date: |
Mon, 19 Jun 2017 16:10:10 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 14.06.2017 um 17:31 hat Max Reitz geschrieben:
> Currently, bdrv_reopen_prepare() assumes that all BDS options are
> strings. However, this is not the case if the BDS has been created
> through the json: pseudo-protocol or blockdev-add.
>
> Note that the user-invokable reopen command is an HMP command, so you
> can only specify strings there. Therefore, specifying a non-string
> option with the "same" value as it was when originally created will now
> return an error because the values are supposedly similar (and there is
> no way for the user to circumvent this but to just not specify the
> option again -- however, this is still strictly better than just
> crashing).
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-block] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare(), Max Reitz, 2017/06/14
- [Qemu-block] [PATCH 2/4] qapi: Add qobject_is_equal(), Max Reitz, 2017/06/14
- [Qemu-block] [PATCH 1/4] qapi/qnull: Add own header, Max Reitz, 2017/06/14
- [Qemu-block] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare(), Max Reitz, 2017/06/14
- Re: [Qemu-block] [PATCH 3/4] block: qobject_is_equal() in bdrv_reopen_prepare(),
Kevin Wolf <=
- [Qemu-block] [PATCH 4/4] iotests: Add test for non-string option reopening, Max Reitz, 2017/06/14
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/4] block: Don't compare strings in bdrv_reopen_prepare(), no-reply, 2017/06/14