Re: [Qemu-block] [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

[Kevin Wolf]

Am 22.05.2017 um 23:11 hat Hervé Poussineau geschrieben:
> Hi,
> 
> This patchset fixes some of issues I encountered when trying to use vvfat, 
> and fixes
> bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539
> 
> Patch 1 fixes a crash when using 'qemu-img convert'.
> Patches 2 to 6 are code cleanup. No functionnal changes.
> Patches 7 to 13 fix problems detected by disk checking utilities in read-only 
> mode.
> 
> With these patches, vvfat creates valid FAT volumes and can be used with QEMU 
> disk utilities.
> 
> Read-write mode is still buggy after this patchset, but at least, I was not
> able to crash QEMU anymore.
> 
> Note that patch 2 doesn't pass checkpatch.pl, as it changes indentation only.

Thanks, fixed the build error in patch 9 (yet unused variables) and
applied to the block branch.

There were a few more minor comments for this series, but it has been on
the list for long enough and I figured that they can be addressed on
top.

Kevin