[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default |
|
Date: |
Thu, 6 Jul 2017 09:40:15 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Mon, Jul 03, 2017 at 01:40:57PM -0500, Eric Blake wrote:
> On 07/03/2017 10:56 AM, Eric Blake wrote:
> > On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote:
> >> The following functions fail if bs->drv does not implement them:
>
> One other suggestion: most patches in the tree use 'topic: Capital',
> while yours used 'topic: lowercase'. It's probably worth posting a v3
> that addresses all of the nits I've pointed out, including tweaking the
> commit messages.
Plenty of regular contributors use "topic: lowercase" including Michael
Tsirkin, Mark Cave-Ayland, Peter Xu, and myself (just from looking at
the first page of git log --oneline on qemu.git/master).
If we want to enforce a consistent style in the future then it should be
discussed separately.
signature.asc
Description: PGP signature