[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] block: remove timer canceling in throttle_c
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH 2/2] block: remove timer canceling in throttle_config() |
|
Date: |
Thu, 6 Jul 2017 10:57:28 +0100 |
|
User-agent: |
Mutt/1.8.0 (2017-02-23) |
On Sun, Jul 02, 2017 at 01:06:46PM +0300, Manos Pitsidianakis wrote:
> throttle_config() cancels the timers of the calling BlockBackend. This
> doesn't make sense because other BlockBackends in the group remain
> untouched. There's no need to cancel the timers in the one specific
> BlockBackend so let's not do that. Throttled requests will run as
> scheduled and future requests will follow the new configuration. This
> also allows a throttle group's configuration to be changed even when it
> has no members.
>
> Signed-off-by: Manos Pitsidianakis <address@hidden>
> ---
> block/throttle-groups.c | 10 +---------
> fsdev/qemu-fsdev-throttle.c | 2 +-
> include/qemu/throttle.h | 1 -
> tests/test-throttle.c | 4 ++--
> util/throttle.c | 14 --------------
> 5 files changed, 4 insertions(+), 27 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature