|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/6] block: Add VFIO based driver for NVMe device |
| Date: | Thu, 6 Jul 2017 16:22:37 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 06/07/2017 16:06, address@hidden wrote:
> ERROR: Use of volatile is usually wrong: see
> Documentation/volatile-considered-harmful.txt
> #843: FILE: block/nvme.c:40:
> + volatile uint32_t *doorbell;
>
> ERROR: Use of volatile is usually wrong: see
> Documentation/volatile-considered-harmful.txt
> #869: FILE: block/nvme.c:66:
> +typedef volatile struct {
Indeed volatile should not be necessary, since we use memory barriers
appropriately. But these are hardware registers (like, host hardware)
so I guess it's okay for this special case.
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |