Re: [Qemu-block] [PATCH v2 1/1] util/aio-win32: Only select on what we are actually waiting for

[Paolo Bonzini]

Looks good, but I noticed now that you may want to do that for
qio_channel_create_socket_watch too.

Paolo

----- Original Message -----
> From: "Alistair Francis" <address@hidden>
> To: address@hidden, address@hidden, address@hidden
> Cc: "alistair francis" <address@hidden>, address@hidden, "edgar iglesias"
> <address@hidden>, address@hidden, address@hidden, address@hidden
> Sent: Thursday, July 6, 2017 10:15:14 PM
> Subject: [PATCH v2 1/1] util/aio-win32: Only select on what we are actually 
> waiting for
> 
> Signed-off-by: Alistair Francis <address@hidden>
> Acked-by: Edgar E. Iglesias <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Changes in V2:
>  - Rebase on master
> Changes since RFC:
>  - Include more bitmasks for the select call
> 
>  util/aio-win32.c | 13 ++++++++++---
>  1 file changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/util/aio-win32.c b/util/aio-win32.c
> index bca496a47a..d6d5e02f00 100644
> --- a/util/aio-win32.c
> +++ b/util/aio-win32.c
> @@ -71,6 +71,7 @@ void aio_set_fd_handler(AioContext *ctx,
>          }
>      } else {
>          HANDLE event;
> +        long bitmask = 0;
>  
>          if (node == NULL) {
>              /* Alloc and insert if it's not already there */
> @@ -95,10 +96,16 @@ void aio_set_fd_handler(AioContext *ctx,
>          node->io_write = io_write;
>          node->is_external = is_external;
>  
> +        if (io_read) {
> +            bitmask |= FD_READ | FD_ACCEPT | FD_CLOSE;
> +        }
> +
> +        if (io_write) {
> +            bitmask |= FD_WRITE | FD_CONNECT;
> +        }
> +
>          event = event_notifier_get_handle(&ctx->notifier);
> -        WSAEventSelect(node->pfd.fd, event,
> -                       FD_READ | FD_ACCEPT | FD_CLOSE |
> -                       FD_CONNECT | FD_WRITE | FD_OOB);
> +        WSAEventSelect(node->pfd.fd, event, bitmask);
>      }
>  
>      qemu_lockcnt_unlock(&ctx->list_lock);
> --
> 2.11.0
> 
>