Re: [Qemu-block] [Qemu-devel] [PATCH v22 24/30] qmp: add autoload parameter to block-dirty-bitmap-add

[Markus Armbruster]

Vladimir Sementsov-Ogievskiy <address@hidden> writes:

> Optional. Default is false.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> Reviewed-by: John Snow <address@hidden>
> ---
>  blockdev.c           | 18 ++++++++++++++++--
>  qapi/block-core.json |  6 +++++-
>  2 files changed, 21 insertions(+), 3 deletions(-)
[...]
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 13f98ec146..5c42cc7790 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1566,11 +1566,15 @@
>  #              Qcow2 disks support persistent bitmaps. Default is false for
>  #              block-dirty-bitmap-add. (Since: 2.10)
>  #
> +# @autoload: the bitmap will be automatically loaded when the image it is 
> stored
> +#            in is opened. This flag may only be specified for persistent
> +#            bitmaps. Default is false for block-dirty-bitmap-add. (Since: 
> 2.10)
> +#

Comments on PATCH 23 apply.

>  # Since: 2.4
>  ##
>  { 'struct': 'BlockDirtyBitmapAdd',
>    'data': { 'node': 'str', 'name': 'str', '*granularity': 'uint32',
> -            '*persistent': 'bool' } }
> +            '*persistent': 'bool', '*autoload': 'bool' } }
>  
>  ##
>  # @block-dirty-bitmap-add: