[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-d
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256 |
Date: |
Fri, 07 Jul 2017 11:00:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
"Daniel P. Berrange" <address@hidden> writes:
> On Fri, Jul 07, 2017 at 10:05:22AM +0200, Markus Armbruster wrote:
>> Vladimir Sementsov-Ogievskiy <address@hidden> writes:
>>
>> > Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> > ---
>> > block/dirty-bitmap.c | 5 +++++
>> > blockdev.c | 25 +++++++++++++++++++++++++
>> > include/block/dirty-bitmap.h | 1 +
>> > include/qemu/hbitmap.h | 8 ++++++++
>> > qapi/block-core.json | 27 +++++++++++++++++++++++++++
>> > tests/Makefile.include | 2 +-
>> > util/hbitmap.c | 11 +++++++++++
>> > 7 files changed, 78 insertions(+), 1 deletion(-)
>> [...]
>> > diff --git a/qapi/block-core.json b/qapi/block-core.json
>> > index 5c42cc7790..6ad8585400 100644
>> > --- a/qapi/block-core.json
>> > +++ b/qapi/block-core.json
>> > @@ -1644,6 +1644,33 @@
>> > 'data': 'BlockDirtyBitmap' }
>> >
>> > ##
>> > +# @BlockDirtyBitmapSha256:
>> > +#
>> > +# SHA256 hash of dirty bitmap data
>> > +#
>> > +# @sha256: ASCII representation of SHA256 bitmap hash
>>
>> Spell it SHA-256, please. The member name @sha256 can stay.
>>
>> SHA-256 is 256 binary bits. Please specify how they are represented in
>> ASCII. It better be base64 (RFC 4648), because we use that elsewhere.
>
> It is filled later in this patch using qcrypto_hash_digest, so it is just
> a hex string representing the hash, not base64. For the latter you can
> use qcrypto_hash_base64
I got two points:
1. Whatever encoding we use, it needs to be documented.
2. The fewer binary -> ASCII encodings we use, the better. We already
use base64.
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Markus Armbruster, 2017/07/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Daniel P. Berrange, 2017/07/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256,
Markus Armbruster <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Vladimir Sementsov-Ogievskiy, 2017/07/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Markus Armbruster, 2017/07/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, John Snow, 2017/07/07
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Markus Armbruster, 2017/07/10
- Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, John Snow, 2017/07/10
Re: [Qemu-block] [Qemu-devel] [PATCH v22 25/30] qmp: add x-debug-block-dirty-bitmap-sha256, Eric Blake, 2017/07/07