[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 01/11] block: prepare write threshold code for t
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 01/11] block: prepare write threshold code for thread safety |
Date: |
Mon, 10 Jul 2017 18:16:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 10/07/2017 15:21, Stefan Hajnoczi wrote:
> On Thu, Jul 06, 2017 at 06:38:18PM +0200, Paolo Bonzini wrote:
>> Code refactoring only.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
>> block/write-threshold.c | 28 ++++++++++++++++------------
>> 1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/block/write-threshold.c b/block/write-threshold.c
>> index 0bd1a01c86..c8ebc32b4d 100644
>> --- a/block/write-threshold.c
>> +++ b/block/write-threshold.c
>> @@ -37,18 +37,22 @@ static void write_threshold_disable(BlockDriverState *bs)
>> }
>> }
>>
>> +static uint64_t exceeded_amount(const BdrvTrackedRequest *req,
>> + uint64_t thres)
>
> Not a reason to respin, but I would prefer a more specific name so the
> intent of the code is easier to understand: exceeded_threshold() instead
> of exceeded_amount().
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
It's the amount by which the request exceeds threshold... Not sure what
name would be best.
Paolo
signature.asc
Description: OpenPGP digital signature
[Qemu-block] [PATCH 05/11] block-backup: add reqs_lock, Paolo Bonzini, 2017/07/06
[Qemu-block] [PATCH 04/11] block: make before-write notifiers thread-safe, Paolo Bonzini, 2017/07/06
[Qemu-block] [PATCH 06/11] block: add a few more notes on locking, Paolo Bonzini, 2017/07/06