[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM |
|
Date: |
Wed, 12 Jul 2017 10:52:52 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/12/2017 07:57 AM, Kevin Wolf wrote:
> If no drive=... option is passed (for an empty drive), we don't only
> lack the BlockBackend normally created by parse_drive(), but we also
> need to manually call blk_attach_dev().
>
> IDE does not support hot unplug, but if it did, qdev would take care to
> call the matching blk_detach_dev() on unplug.
>
> This fixes at least the bug that such devices didn't show up in
> query-block, and probably some more problems.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> hw/ide/qdev.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 3/9] block: Make blk_all_next() public, (continued)
- [Qemu-block] [PATCH 3/9] block: Make blk_all_next() public, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 2/9] block/qapi: Add qdev device name to query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 4/9] block/qapi: Use blk_all_next() for query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 5/9] block: List anonymous device BBs in query-block, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- Re: [Qemu-block] [PATCH 6/9] ide: bdrv_attach_dev() for empty CD-ROM,
Eric Blake <=
- [Qemu-block] [PATCH 7/9] scsi-disk: bdrv_attach_dev() for empty CD-ROM, Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 8/9] qemu-iotests: Test 'info block', Kevin Wolf, 2017/07/12
- [Qemu-block] [PATCH 9/9] qemu-iotests: Test unplug of -device without drive, Kevin Wolf, 2017/07/12