[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert int
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity |
|
Date: |
Wed, 12 Jul 2017 16:25:14 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/12/2017 04:00 PM, John Snow wrote:
>
>
> On 07/03/2017 11:10 AM, Eric Blake wrote:
>> Now that all callers are using byte-based interfaces, there's no
>> reason for our internal hbitmap to remain with sector-based
>> granularity. It also simplifies our internal scaling, since we
>> already know that hbitmap widens requests out to granularity
>> boundaries.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>>
>> @@ -310,7 +305,6 @@ void bdrv_dirty_bitmap_truncate(BlockDriverState *bs)
>> int64_t size = bdrv_getlength(bs);
>>
>> assert(size >= 0);
>> - size = DIV_ROUND_UP(size, BDRV_SECTOR_SIZE);
>
> whoops uh, were we setting bitmap->size to the *sector* size prior to
> this, even though we had already changed bitmap->size to be the byte size?
Oops. Looks like I have a bug in my rebasing of 5/17. Good catch; I'll
have to post v5.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 13/17] mirror: Switch mirror_dirty_init() to byte-based iteration, (continued)
- [Qemu-block] [PATCH v4 13/17] mirror: Switch mirror_dirty_init() to byte-based iteration, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 15/17] qcow2: Switch store_bitmap_data() to byte-based iteration, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 14/17] qcow2: Switch load_bitmap_data() to byte-based iteration, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 16/17] dirty-bitmap: Switch bdrv_set_dirty() to bytes, Eric Blake, 2017/07/03
- [Qemu-block] [PATCH v4 17/17] dirty-bitmap: Convert internal hbitmap size/granularity, Eric Blake, 2017/07/03