qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] qapi: Stop abusing "special" values for something entir


From: Daniel P. Berrange
Subject: Re: [Qemu-block] qapi: Stop abusing "special" values for something entirely different
Date: Mon, 17 Jul 2017 10:02:28 +0100
User-agent: Mutt/1.8.3 (2017-05-23)

On Fri, Jul 14, 2017 at 07:12:52PM +0200, Markus Armbruster wrote:
> Here's what I propose to do:
> 
> 1. Stop abusing values the schema accepts, but are invalid to mean "do
> something else entirely".
> 
> 2. Add a first class null type to QAPI.
> 
> 3. Turn MigrationParameters members tls-creds and tls-hostname into
> alternate of str and null.  Deprecate "".
> 
> 4. Add a null member to alternate BlockdefRef.  Deprecate "".
> 
> I got patches for 2., and I intend to work on 3. and 4.
> 
> Since this is "only" about "less than general and ugly", we may decide
> to leave things as they are if my patches turn out even uglier.
> 
> Meanwhile, opinions?

That sounds ok in principle to me, so worth at least proposing the patches
so we can see how it works out in practice.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]