[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 2/2] file-posix: Do runtime check for ofd lock A
From: |
Andrew Baumann |
Subject: |
Re: [Qemu-block] [PATCH 2/2] file-posix: Do runtime check for ofd lock API |
Date: |
Fri, 21 Jul 2017 17:23:24 +0000 |
> From: Fam Zheng [mailto:address@hidden
> Sent: Friday, 21 July 2017 3:21
>
> It is reported that on Windows Subsystem for Linux, ofd operations fail
> with -EINVAL. In other words, QEMU binary built with system headers that
> exports F_OFD_SETLK doesn't necessarily run in an environment that
> actually supports it:
>
> $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0 \
> -device virtio-blk-pci,drive=hd0
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to unlock
> byte 100
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to unlock
> byte 100
> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to lock
> byte 100
>
> Let's do a runtime check to cope with that.
>
> Reported-by: Andrew Baumann <address@hidden>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/file-posix.c | 19 ++++++++-----------
> 1 file changed, 8 insertions(+), 11 deletions(-)
If it helps:
Tested-By: Andrew Baumann <address@hidden>
Thanks!
Andrew