[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/2] iotests: Fix test 156
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 1/2] iotests: Fix test 156 |
Date: |
Tue, 25 Jul 2017 12:26:31 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/25/2017 10:56 AM, Max Reitz wrote:
> On one hand, the _make_test_img invocation for creating the target image
> was missing a -u because its backing file is not supposed to exist at
> that point.
>
> On the other hand, nobody noticed probably because the backing file is
> created later on and _cleanup failed to remove it: The quotation marks
> were misplaced so bash tried to deleted a file literally called
s/deleted/delete/
> "$TEST_IMG{,.target}..." instead of resolving the globs. Thus, the
Technically brace expansion, not globs.
> files stayed around after the first run and qemu-img create did not
> complain about a missing backing file on any run but the first.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/156 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature