[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format |
Date: |
Tue, 25 Jul 2017 16:41:16 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 07/25/2017 09:41 AM, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <address@hidden>
> ---
> block/qcow2-cluster.c | 15 +++++++++++++++
> block/qcow2.c | 25 ++++++++++++++++++++++++-
> configure | 2 +-
> docs/interop/qcow2.txt | 2 ++
> qapi/block-core.json | 15 ++++++++++++---
> qemu-img.texi | 1 +
> 6 files changed, 55 insertions(+), 5 deletions(-)
>
> +++ b/docs/interop/qcow2.txt
> @@ -335,6 +335,8 @@ The fields of the compress format extension are:
> deflate: Standard zlib deflate compression without
> compression header
>
> + lzo: LZO1X compression without additional header
> +
> 14: compress_level (uint8_t)
>
> 0 = default compress level (valid for all formats,
> default)
What do compress_level and compress_window have to be for lzo? (If they
are not useful, document that it must be 0 - which you've already done
for compress_level).
> +# @Qcow2CompressLZO:
> +#
> +# Since: 2.10
2.11
> +##
> +{ 'struct': 'Qcow2CompressLZO',
> + 'data': { } }
> +
> +##
> # @Qcow2Compress:
> #
> # Specifies the compression format and compression level that should
> @@ -2491,8 +2500,8 @@
> { 'union': 'Qcow2Compress',
> 'base': { 'format': 'Qcow2CompressFormat' },
> 'discriminator': 'format',
> - 'data': { 'deflate': 'Qcow2CompressDeflate' } }
> -
> + 'data': { 'deflate': 'Qcow2CompressDeflate',
> + 'lzo': 'Qcow2CompressLZO' } }
>
Was the loss of the blank line intentional?
> +++ b/qemu-img.texi
> @@ -682,6 +682,7 @@ The following options are available if support for the
> respective libraries
> has been enabled at compile time:
>
> deflate Uses standard zlib defalte compression
> + lzo Uses LZO1X compression
The .json file spelled it lzo1x; is there a difference implied by the
choice of capitalization?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH V5 01/10] specs/qcow2: add compress format extension, (continued)
- [Qemu-block] [PATCH V5 10/10] block/qcow2: add compress info to image specific info, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 03/10] block/qcow2: parse compress create options, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 06/10] block/qcow2: simplify ret usage in qcow2_create, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format, Peter Lieven, 2017/07/25
- Re: [Qemu-block] [PATCH V5 09/10] block/qcow2: add lzo compress format,
Eric Blake <=
- [Qemu-block] [PATCH V5 07/10] block/qcow2: optimize qcow2_co_pwritev_compressed, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 05/10] block/qcow2: read and write the compress format extension, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 04/10] qemu-img: add documentation for compress settings, Peter Lieven, 2017/07/25
- [Qemu-block] [PATCH V5 08/10] block/qcow2: start using the compress format extension, Peter Lieven, 2017/07/25