[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087 |
Date: |
Wed, 26 Jul 2017 10:49:51 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Jul 26, 2017 at 04:55:39PM +0800, Jing Liu wrote:
>
>
> On 2017/7/25 下午11:48, Daniel P. Berrange wrote:
> > On Tue, Jul 25, 2017 at 04:45:46PM +0100, Stefan Hajnoczi wrote:
> > > On Mon, Jul 24, 2017 at 02:44:13PM +0800, Jing Liu wrote:
> > > > On 2017/7/21 上午11:47, Cleber Rosa wrote:
> > > > > One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO.
> > > > >
> > > > > As a PoC/RFC, this goes the easy route and skips the test as a whole
> > > > > when that feature is missing. Other approaches include splitting
> > > > > the test and adding extra filtering.
> > > > >
> > > > > Signed-off-by: Cleber Rosa <address@hidden>
> > > > > ---
> > > > > tests/qemu-iotests/087 | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087
> > > > > index f8e4903..a2fb7de 100755
> > > > > --- a/tests/qemu-iotests/087
> > > > > +++ b/tests/qemu-iotests/087
> > > > > @@ -34,6 +34,7 @@ status=1 # failure is the default!
> > > > > _supported_fmt qcow2
> > > > > _supported_proto file
> > > > > _supported_os Linux
> > > > > +_require_feature CONFIG_LINUX_AIO
> > > > I tested that CONFIG_NETTLE_KDF is also a necessary for 087.
> > > >
> > > > +_require_feature CONFIG_NETTLE_KDF
> > > Are you sure? Looks like either nettle or gcrypt is needed:
> > Correct, it works with either.
> Ah, because I just found out nettle which related to KDF.
> why can not find out gcrypt.h in qemu?
> How to compile config_gcrypt_kdf into qemu?
QEMU picks either nettle or libgcrypt automatically, dependant on which
of these gnutls is linked to.
You can force override this via --disable-nettle --enable-gcrypt
(or vica-verca), for sake of testing, but you shouldn't do that
for production builds.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-block] [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip, (continued)
[Qemu-block] [PATCH 2/3] qemu-iotests: add _require_feature() function, Cleber Rosa, 2017/07/21
[Qemu-block] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087, Cleber Rosa, 2017/07/21
[Qemu-block] [PATCH 1/3] scripts: introduce buildconf.py, Cleber Rosa, 2017/07/21