[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 1/1] nbd: fix memory leak in nbd_opt_go()
From: |
Eric Blake |
Subject: |
[Qemu-block] [PULL 1/1] nbd: fix memory leak in nbd_opt_go() |
Date: |
Fri, 28 Jul 2017 12:02:54 -0500 |
From: Philippe Mathieu-Daudé <address@hidden>
nbd/client.c:385:12: warning: Potential leak of memory pointed to by 'buf'
Reported-by: Clang Static Analyzer
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-Id: <address@hidden>
[introduced in commit 8ecaeae8]
Signed-off-by: Eric Blake <address@hidden>
---
nbd/client.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index 509ed5e4ba..0a17de80b5 100644
--- a/nbd/client.c
+++ b/nbd/client.c
@@ -376,9 +376,11 @@ static int nbd_opt_go(QIOChannel *ioc, const char
*wantname,
if (info->request_sizes) {
stw_be_p(buf + 4 + len + 2, NBD_INFO_BLOCK_SIZE);
}
- if (nbd_send_option_request(ioc, NBD_OPT_GO,
- 4 + len + 2 + 2 * info->request_sizes, buf,
- errp) < 0) {
+ error = nbd_send_option_request(ioc, NBD_OPT_GO,
+ 4 + len + 2 + 2 * info->request_sizes,
+ buf, errp);
+ g_free(buf);
+ if (error < 0) {
return -1;
}
--
2.13.3
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-block] [PULL 1/1] nbd: fix memory leak in nbd_opt_go(),
Eric Blake <=