qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-block] Is the use of bdrv_getlength() in vmdk_check() kosher?


From: Markus Armbruster
Subject: [Qemu-block] Is the use of bdrv_getlength() in vmdk_check() kosher?
Date: Fri, 04 Aug 2017 15:28:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Have a look at vmdk_check():

        if (ret == VMDK_OK &&
            cluster_offset >= bdrv_getlength(extent->file->bs))

bdrv_getlength() can fail.  Does it do the right thing then?  For what
it's worth, the comparison of its value is unsigned.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]