|
From: | Juan Quintela |
Subject: | Re: [Qemu-block] [RFC PATCH 16/56] migration: Make XBZRLE transferred size unsigned in QAPI/QMP |
Date: | Mon, 07 Aug 2017 18:47:32 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Markus Armbruster <address@hidden> wrote: > Sizes should use QAPI type 'size' (uint64_t). XBZRLECacheStats member > @bytes is 'int' (int64_t). save_xbzrle_page() computes the byte count > increment in size_t, implicitly converts it to int, then adds that to > @bytes. > > Change the XBZRLECacheStats member to 'size' and clean up > save_xbzrle_page(). > > query-migrate now reports transferred sizes above 2^63-1 correctly > instead of their (negative) two's complement. > > HMP's "info migrate" already reported them correctly, because it > printed the signed integer with PRIu64. > > Signed-off-by: Markus Armbruster <address@hidden> Reviewed-by: Juan Quintela <address@hidden>
[Prev in Thread] | Current Thread | [Next in Thread] |