Re: [Qemu-block] [Qemu-devel] [PATCH] iotests: fix 185

[Vladimir Sementsov-Ogievskiy]

08.08.2017 18:07, Eric Blake wrote:
> On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
>
> > > > > Throttling "guaranties" that there will not be more than one
> > > > > request. But
> > > > > what prevent less than one, i.e. zero, like in my reproduction?
> > > > Yes, I understand. Can we somehow make sure that at least one iteration
> > > > is made? I'd really like to keep the functional test for block job
> > > > throttling. I suppose a simple 'sleep 0.1' would do the trick, though
> > > > it's not very clean.
> > > >
> > > > Kevin
> > >
> > > I've started with 'sleep 0.5', now there are >100 successful
> > > iterations... The other way is to check in test that there was 0 or 1
> > > requests, but for this it looks better to rewrite it in python.
> > is sleep for ms portable?
> Sadly, sub-second sleep is a GNU coreutils feature; I suspect the BSD
> machines may fail to parse it.  (Of course, we could do some sort of
> 'sleep $SMALL', where $SMALL is 0.5 if sleep supports it, and 1 otherwise).
sleep for 1 second may lead to more then one request done before qemu quite.


--
Best regards,
Vladimir