qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 for 2.10] iotests: fix 185


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH v2 for 2.10] iotests: fix 185
Date: Wed, 9 Aug 2017 18:57:36 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

09.08.2017 18:41, Eric Blake wrote:
On 08/09/2017 10:19 AM, Vladimir Sementsov-Ogievskiy wrote:
09.08.2017 18:17, Vladimir Sementsov-Ogievskiy wrote:
185 can sometimes produce wrong output like this:

This is because quite happens before first mirror request is done
s/quite/quit/

(and, in specified case, even before block-job len field is set).
To prevent it let's just add a sleep for 0.3 seconds before quite.
Here, as well.

Maybe:

This is because, under heavy load, the quit can happen before the first
iteration of the mirror request has occurred.  To make sure we've had
time to iterate, let's just add a sleep for 0.3 seconds before quitting.


       "return"
   +# If we don't sleep here 'quit' command may be handled before
+# the first mirror iteration is done
+sleep 0.5
The commit message disagrees with the code (.3 vs. .5) - which one is
correct?

Let it be .5, as I've tested it.


--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]