[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in p
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr |
Date: |
Thu, 10 Aug 2017 13:35:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
On 08/10/2017 11:04 AM, Daniel P. Berrange wrote:
> The inet_parse() function looks for 'ipv4' and 'ipv6'
> flags, but only treats them as bare bool flags. The normal
> QemuOpts parsing would allow on/off values to be set too.
>
> This updated inet_parse() so that its handling of the
s/updated/updates/ ?
> 'ipv4' and 'ipv6' flags matches that done by QemuOpts.
Do we have a regression compared to any previous version, such that this
patch might be considered 2.10 material? Offhand, though, I think it's
fine as the end of your series, waiting for 2.11.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> tests/test-sockets-proto.c | 13 -------------
> util/qemu-sockets.c | 36 ++++++++++++++++++++++++++++++++----
> 2 files changed, 32 insertions(+), 17 deletions(-)
>
> +++ b/util/qemu-sockets.c
> @@ -616,6 +616,25 @@ err:
> }
>
> /* compatibility wrapper */
> +static int inet_parse_flag(const char *flagname, const char *optstr, bool
> *val,
> + Error **errp)
> +{
> + char *end;
> + size_t len;
> +
> + end = strstr(optstr, ",");
Do we need to check that we are not landing on a ',,' escape that would
make QemuOpts behave differently? [That is, ipv4=on,,garbage should be
parsed as setting ipv4 to 'on,garbage' (which is not valid), and NOT
setting 'ipv4=on' followed by the 'garbage' or ',garbage' key - while
the key named 'garbage' would fail, there might be other key names where
the distinction matters for catching command line typos]
But if this is unrelated to QemuOpts escape parsing, it seems okay.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 2/8] io: introduce a network socket listener API, (continued)
[Qemu-block] [PATCH 3/8] blockdev: convert internal NBD server to QIONetListener, Daniel P. Berrange, 2017/08/10
[Qemu-block] [PATCH 4/8] blockdev: convert qemu-nbd server to QIONetListener, Daniel P. Berrange, 2017/08/10
[Qemu-block] [PATCH 5/8] migration: convert socket server to QIONetListener, Daniel P. Berrange, 2017/08/10
[Qemu-block] [PATCH 6/8] chardev: convert the socket server to QIONetListener, Daniel P. Berrange, 2017/08/10
[Qemu-block] [PATCH 7/8] ui: convert VNC server to QIONetListener, Daniel P. Berrange, 2017/08/10
[Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr, Daniel P. Berrange, 2017/08/10
- Re: [Qemu-block] [PATCH 8/8] sockets: fix parsing of ipv4/ipv6 opts in parse_socket_addr,
Eric Blake <=
Re: [Qemu-block] [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack support, no-reply, 2017/08/10
Re: [Qemu-block] [Qemu-devel] [PATCH 0/8] Enable full IPv4/IPv6 dual stack support, no-reply, 2017/08/10