Re: [Qemu-block] [PATCH 00/17] nbd client refactoring and fixing

[Vladimir Sementsov-Ogievskiy]

17.08.2017 00:21, Eric Blake wrote:
> On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote:
> > A bit more refactoring and fixing before BLOCK_STATUS series.
> > I've tried to make individual patches simple enough, so there are
> > a lot of them.
> Is your BLOCK_STATUS series something that is in good enough shape to
> post a preliminary version of it (the version you posted back in
> February is now horribly out-of-date, with all the good cleanups you
> have been doing in the meantime).  I want to get a running start at
> reviewing what I can to make sure we get improved NBD functionality into
> 2.11.

Every time I want to produce a new version of BLOCK_STATUS, I stumble on
something and new 10-20 patches refactoring series appears)

> Also, please feel free to offer your Reviewed-by on other patches
> (whether NBD-related or not).  Speaking as the NBD maintainer, I welcome
> any help I can get.  And from personal experience, reviews tend to be
> one of the largest bottlenecks in open source software - if you are
> writing patches but not offering reviews, then you are adding to the
> bottleneck so reviewers tend to set your patches aside for when they
> have more time; while if you are actively offering reviews, then it is
> obvious that you care about the project and your patch contributions
> tend to have an easier time getting in.  My personal rule of thumb is to
> try and review at least 2 other patches for every one that I send,
> although that is a rather ambitious goal and there's nothing wrong if
> you can't commit to theh same level of effort.

Thanks, I get the point, I'll try to do better.


> > Vladimir Sementsov-Ogievskiy (17):
> >    nbd/client: fix nbd_opt_go
> >    nbd/client: refactor nbd_read_eof
> >    nbd/client: refactor nbd_receive_reply
> >    nbd/client: fix nbd_send_request to return int
> >    block/nbd-client: get rid of ssize_t
> >    block/nbd-client: fix nbd_read_reply_entry
> >    block/nbd-client: refactor request send/receive
> >    block/nbd-client: rename nbd_recv_coroutines_enter_all
> >    block/nbd-client: move nbd_co_receive_reply content into
> >      nbd_co_request
> >    block/nbd-client: move nbd_coroutine_end content into nbd_co_request
> >    block/nbd-client: fix nbd_co_request: set s->reply.handle to 0 on
> >      error
> >    block/nbd-client: refactor nbd_co_request
> >    block/nbd-client: refactor NBDClientSession.recv_coroutine
> >    block/nbd-client: exit reply-reading coroutine on incorrect handle
> >    block/nbd-client: refactor reading reply
> >    block/nbd-client: drop reply field from NBDClientSession
> >    block/nbd-client: always return EIO on and after the first io channel
> >      error
> Of course, parts of this will need rebasing based on what finally landed
> in 2.10, but I can start reviewing what I can for this round.

--
Best regards,
Vladimir