[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-iotests: Extend non-shared
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3] qemu-iotests: Extend non-shared storage migration test (194) |
Date: |
Tue, 29 Aug 2017 16:16:54 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 08/29/2017 12:42 PM, Stefan Hajnoczi wrote:
> On Tue, Aug 29, 2017 at 5:50 PM, Kashyap Chamarthy <address@hidden> wrote:
>> This is the follow-up patch that was discussed[*] as part of feedback to
>> qemu-iotest 194.
>>
>> Signed-off-by: Kashyap Chamarthy <address@hidden>
>> ---
>> Changes in v3:
>> - Wait for migration to complete before issuing `block-job-cancel`
>> (StefanH)
>> - Wait for the event BLOCK_JOB_COMPLETED on the source before stopping
>> the NBD server on the destination (StefanH)
>>
>> Changes in v2:
>> - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (EricB)
>> ---
>> tests/qemu-iotests/194 | 23 +++++++++++++++++------
>> tests/qemu-iotests/194.out | 11 ++++++++---
>> 2 files changed, 25 insertions(+), 9 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
Thanks; I've added this to my NBD queue (pull request to come shortly
after 2.11 release is finalized), since the test uses NBD.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature