Re: [Qemu-block] [Qemu-devel] [PATCH v9 6/6] qemu-iotests: add 184 for throttle filter driver

[Kevin Wolf]

Am 06.09.2017 um 10:26 hat Manos Pitsidianakis geschrieben:
> On Tue, Sep 05, 2017 at 04:13:39PM -0500, Eric Blake wrote:
> > On 09/05/2017 02:06 PM, Kevin Wolf wrote:
> > > Am 05.09.2017 um 18:16 hat Kevin Wolf geschrieben:
> > > > Am 25.08.2017 um 15:20 hat Manos Pitsidianakis geschrieben:
> > > > > Reviewed-by: Alberto Garcia <address@hidden>
> > > > > Signed-off-by: Manos Pitsidianakis <address@hidden>
> > > > 
> > > > Does this test actually (still) pass for you? I can't see that it's
> > > > related to any recent change in master, but this is the diff that I get.
> > > > 
> > > > I can update the reference output while applying, but obviously if it's
> > > > currently passing for you, it will fail after I "fix" it.
> > > 
> > > For the record, we discussed this on IRC. The test works correctly on
> > > master, but on my block branch there is a conflict with "block: pass
> > > bdrv_* methods to bs->file by default in block filters".
> > > 
> > > The correct action is to merge this throttle driver series after the
> > > conflicting patch because throttle doesn't implement .bdrv_get_info and
> > > needs the forwarding that the other patch implements.
> > > 
> > > I updated the test output accordingly and applied the series to my block
> > > branch.
> > 
> > Could you also squash this in to 5/6? (as long as we're intentionally
> > basing throttle on top of defaults, then we should use the right default
> > instead of duplicating things)
> 
> Yes, this change makes sense, if it's no trouble with Kevin.

Already done, I was just waiting for your opinion. :-)

Kevin

signature.asc
Description: PGP signature