Re: [Qemu-block] [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks

[Manos Pitsidianakis]

On Thu, Sep 21, 2017 at 09:35:35PM +0800, Fam Zheng wrote:
> On Thu, 09/21 16:17, Manos Pitsidianakis wrote:
> > This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new
> > bdrv_co_drain_end callback to match bdrv_drained_begin/end and
> > drained_begin/end of BdrvChild. This is needed because the throttle driver
> > (block/throttle.c) needs a way to mark the end of the drain in order to toggle
> > io_limits_disabled correctly.
>
> Is this a bug fix? I.e. do we need to Cc address@hidden
>
> Fam

No that's not needed, throttle is not in 2.10. The bug in this case is 
that the drain would wait for the throttled requests to be completed as 
they were scheduled by the I/O throttling instead of restarting the 
queue and scheduling them right away.

signature.asc
Description: PGP signature