[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointe
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer |
Date: |
Fri, 22 Sep 2017 17:43:53 +0300 |
Without initialization to zero dirty_bitmap field may be not zero
for a bitmap which should not be stored and
qcow2_store_persistent_dirty_bitmaps will erroneously call
store_bitmap for it which leads to SYGSEGV on bdrv_dirty_bitmap_name.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/qcow2-bitmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qcow2-bitmap.c b/block/qcow2-bitmap.c
index e8d3bdbd6e..14f41d0427 100644
--- a/block/qcow2-bitmap.c
+++ b/block/qcow2-bitmap.c
@@ -602,7 +602,7 @@ static Qcow2BitmapList *bitmap_list_load(BlockDriverState
*bs, uint64_t offset,
goto fail;
}
- bm = g_new(Qcow2Bitmap, 1);
+ bm = g_new0(Qcow2Bitmap, 1);
bm->table.offset = e->bitmap_table_offset;
bm->table.size = e->bitmap_table_size;
bm->flags = e->flags;
--
2.11.1
- [Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer,
Vladimir Sementsov-Ogievskiy <=
- Re: [Qemu-block] [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer, Eric Blake, 2017/09/22
- Re: [Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer, Vladimir Sementsov-Ogievskiy, 2017/09/23
- Re: [Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer, Stefan Hajnoczi, 2017/09/25
- Re: [Qemu-block] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer, Max Reitz, 2017/09/25
- Re: [Qemu-block] [Qemu-devel] [PATCH] block/qcow2-bitmap: fix use of uninitialized pointer, Michael Roth, 2017/09/25