[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify repl
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission |
Date: |
Thu, 12 Oct 2017 17:35:23 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/12/2017 05:27 PM, Eric Blake wrote:
> On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Send qiov via qio_channel_writev_all instead of calling nbd_write twice
>> with a cork.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> nbd/server.c | 50 ++++++++++++++++++++++++--------------------------
>> 1 file changed, 24 insertions(+), 26 deletions(-)
>>
>
>> @@ -1203,36 +1220,17 @@ static int nbd_co_send_simple_reply(NBDClient
>> *client,
>> size_t len,
>> Error **errp)
>> {
>> - NBDSimpleReply simple_reply;
>> - int ret;
>> -
>> - g_assert(qemu_in_coroutine());
>> + NBDSimpleReply reply;
>
> Why the rename from simple_reply to reply?
>
>> + struct iovec iov[] = {
>> + {.iov_base = &reply, .iov_len = sizeof(reply)},
>
> I guess it made this line shorter. But we could reduce some churn by
> naming it 'reply' in the first place, back in earlier patches. At the
> same time, I'm not going to bother if there's not a reason to respin the
> series (or at least the first half).
Answering myself - you couldn't use the name 'reply' until 5/13 removed
it as a parameter name, even though you introduced the name
'simple_reply' in 4/13. Okay, the rename is fine here.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 00/13] nbd minimal structured read, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 07/13] nbd-server: simplify reply transmission, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 02/13] block/nbd-client: refactor nbd_co_receive_reply, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 06/13] nbd/server: refactor nbd_co_send_simple_reply parameters, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request, Vladimir Sementsov-Ogievskiy, 2017/10/12
- [Qemu-block] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c, Vladimir Sementsov-Ogievskiy, 2017/10/12