[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v1 1/1] iotests: fix the actual-size in 191.out |
|
Date: |
Mon, 16 Oct 2017 07:31:47 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/16/2017 03:30 AM, Kevin Wolf wrote:
> Am 16.10.2017 um 07:23 hat QingFeng Hao geschrieben:
>> The actual-size set in 191.out is wrong, which causes the test case failed
>> and shall be 331776.
>> The actual-size indicates the image's (e.g. t.qcow2.base) actual size
>> defined by ImageInfo.actual_size.
>>
>> Signed-off-by: QingFeng Hao <address@hidden>
>
> This is wrong. It may make the test work on your machine, but it breaks
> it on mine.
>
> The correct approach to fix this is Max' "[PATCH 2/2] iotests: Filter
> actual image size in 184 and 191".
That, and ALL patches should be sent to address@hidden, in
addition to whatever other lists are appropriate (you are correct that
this patch should cc qemu-block, but you forgot qemu-devel).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature