Re: [Qemu-block] [Qemu-devel] [PATCH v4 00/10] qemu-iotests improvements

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v4 00/10] qemu-iotests improvements

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fcf7bb55c6 qemu-iotests: add support for running multi-threaded iotests
889bd2c3ad qemu-iotests: add option to save temp files on error
f5e4c7cbb8 qemu-iotests: modify python tests to run from subdir
9856e37a97 qemu-iotests: run python tests in own subdirectories
19d3ca437b qemu-iotests: make ./check automatically reap QEMU processes
be8a4b4ad9 qemu-iotests: change qemu pid and fd tracking / cleanup
dc36a2b86b qemu-iotests: remove file cleanup from bash tests
a91287ab9f qemu-iotests: automatically clean up bash protocol servers
4fe57fd7b7 qemu-iotests: set TEST_DIR to a unique dir for each test
b24cf5edfd qemu-iotests: refuse to run if TEST_DIR contains spaces

=== OUTPUT BEGIN ===
Checking PATCH 1/10: qemu-iotests: refuse to run if TEST_DIR contains spaces...
Checking PATCH 2/10: qemu-iotests: set TEST_DIR to a unique dir for each test...
Checking PATCH 3/10: qemu-iotests: automatically clean up bash protocol 
servers...
Checking PATCH 4/10: qemu-iotests: remove file cleanup from bash tests...
Checking PATCH 5/10: qemu-iotests: change qemu pid and fd tracking / cleanup...
Checking PATCH 6/10: qemu-iotests: make ./check automatically reap QEMU 
processes...
Checking PATCH 7/10: qemu-iotests: run python tests in own subdirectories...
ERROR: line over 90 characters
#47: FILE: tests/qemu-iotests/iotests.py:267:
+        self.workdir = os.path.join(test_dir, self.__class__.__name__, 
self._testMethodName)

total: 1 errors, 0 warnings, 16 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 8/10: qemu-iotests: modify python tests to run from subdir...
Checking PATCH 9/10: qemu-iotests: add option to save temp files on error...
Checking PATCH 10/10: qemu-iotests: add support for running multi-threaded 
iotests...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden