qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Use -nographic in 18


From: Kashyap Chamarthy
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: Use -nographic in 182
Date: Mon, 30 Oct 2017 14:54:38 +0100
User-agent: Mutt/1.6.0.1 (2016-04-01)

On Mon, Oct 30, 2017 at 11:13:21AM +0100, Kevin Wolf wrote:
> Am 30.10.2017 um 09:39 hat Kashyap Chamarthy geschrieben:
> > On Sun, Oct 29, 2017 at 01:53:38PM +0100, Kevin Wolf wrote:

[...]

> > >  echo
> > >  echo "Starting a second QEMU using the same image should fail"
> > > -echo 'quit' | $QEMU -monitor stdio \
> > > +echo 'quit' | $QEMU -nographic -monitor stdio \
> > 
> > Isn't "-display none" preferred instead of "-nographic"?

[...]

> It's not the same thing, -nographic does more than just that, like
> redirecting the serial port to stdio.

True, because in this test case the monitor is being sent explicitly to
'stdio'.  To your point, I now vaguely recall Paolo saying on IRC that
'-nographic' is a shorthand for:

    '-serial mon:stdio -machine graphics=off -display none'

> In this specific case, -display
> none should actually be enough, but for consistency I just did the same
> thing as other qemu-iotest cases are doing.

Ah, okay.  At any rate:

    Reviewed-by: Kashyap Chamarthy <address@hidden>

-- 
/kashyap



reply via email to

[Prev in Thread] Current Thread [Next in Thread]