Re: [Qemu-block] [PATCH 2/4] qcow2: Prevent allocating L2 tables at offset 0

[Alberto Garcia]

On Thu 02 Nov 2017 06:31:18 PM CET, Max Reitz wrote:
>> +    /* If we're allocating the table at offset 0 then something is wrong */
>> +    if (l2_offset == 0) {
>> +        qcow2_signal_corruption(bs, true, -1, -1, "Preventing invalid "
>> +                                "allocation of L2 table at offset 0");
>> +        return -EIO;
>
> The other error paths in this function use a goto fail.  It doesn't
> make a functional difference, but not doing it here looks a bit weird.

Oh, you're right. I'll fix it.

Berto