[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 3/4] block/parallels: add migration blocker
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v3 3/4] block/parallels: add migration blocker |
Date: |
Tue, 7 Nov 2017 10:04:17 +0000 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Mon, Nov 06, 2017 at 09:31:21PM -0500, Jeff Cody wrote:
> @@ -720,6 +722,16 @@ static int parallels_open(BlockDriverState *bs, QDict
> *options, int flags,
> s->bat_dirty_bmap =
> bitmap_new(DIV_ROUND_UP(s->header_size, s->bat_dirty_block));
>
> + /* Disable migration until bdrv_invalidate_cache method is added */
> + error_setg(&s->migration_blocker, "The Parallels format used by node
> '%s' "
> + "does not support live migration",
> + bdrv_get_device_or_node_name(bs));
> + ret = migrate_add_blocker(s->migration_blocker, &local_err);
> + if (local_err) {
> + error_propagate(errp, local_err);
> + error_free(s->migration_blocker);
> + goto fail;
> + }
Please call migrate_del_blocker() and error_free() in .bdrv_close().
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v3 0/4] Don't write headers if BDS is INACTIVE, Jeff Cody, 2017/11/06
- [Qemu-block] [PATCH v3 1/4] block/vhdx.c: Don't blindly update the header, Jeff Cody, 2017/11/06
- [Qemu-block] [PATCH v3 2/4] block/parallels: Do not update header or truncate image when INMIGRATE, Jeff Cody, 2017/11/06
- [Qemu-block] [PATCH v3 4/4] qemu-iotests: update unsupported image formats in 194, Jeff Cody, 2017/11/06
- [Qemu-block] [PATCH v3 3/4] block/parallels: add migration blocker, Jeff Cody, 2017/11/06
- Re: [Qemu-block] [PATCH v3 3/4] block/parallels: add migration blocker,
Stefan Hajnoczi <=
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/4] Don't write headers if BDS is INACTIVE, Fam Zheng, 2017/11/07