[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 4/5] iotests: Make 083 less flaky
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH v2 4/5] iotests: Make 083 less flaky |
|
Date: |
Fri, 10 Nov 2017 16:51:50 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 10 Nov 2017 04:18:15 PM CET, Max Reitz wrote:
> On 2017-11-10 11:02, Alberto Garcia wrote:
>> On Thu 09 Nov 2017 09:30:24 PM CET, Max Reitz wrote:
>>> + echo > "$TEST_DIR/nbd-fault-injector.out"
>>> $PYTHON nbd-fault-injector.py $extra_args "$nbd_addr"
>>> "$TEST_DIR/nbd-fault-injector.conf" >"$TEST_DIR/nbd-fault-injector.out"
>>> 2>&1 &
>>
>> It seems that in this patch you're indenting with spaces but this file
>> uses tabs.
>
> Yes, but tabs are wrong. :-)
I actually agree with you, but don't mix them in the file :-)
Berto
[Qemu-block] [PATCH v2 5/5] iotests: Make 136 less flaky, Max Reitz, 2017/11/09
Re: [Qemu-block] [PATCH v2 0/5] iotests: Make some tests less flaky, Max Reitz, 2017/11/09