[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 0/3] block: Error out on l
From: |
John Snow |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps |
Date: |
Mon, 20 Nov 2017 19:37:30 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 |
On 11/20/2017 09:50 AM, Kevin Wolf wrote:
> Following the discussing at
> https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg03572.html
> this implements the error return for loading a snapshot while dirty
> bitmaps are active.
>
> Kevin Wolf (3):
> block: Add errp to bdrv_snapshot_goto()
> block: Add errp to bdrv_all_goto_snapshot()
> block: Error out on load_vm with active dirty bitmaps
>
> include/block/snapshot.h | 6 ++++--
> block/snapshot.c | 43 +++++++++++++++++++++++--------------------
> migration/savevm.c | 6 +++---
> qemu-img.c | 6 +++---
> 4 files changed, 33 insertions(+), 28 deletions(-)
>
You have enough reviews, but just so it's unambiguous, I'm fine with
this approach in lieu of Vladimir's; so:
Reviewed-by: John Snow <address@hidden>
- [Qemu-block] [PATCH for-2.11 1/3] block: Add errp to bdrv_snapshot_goto(), (continued)
- [Qemu-block] [PATCH for-2.11 2/3] block: Add errp to bdrv_all_goto_snapshot(), Kevin Wolf, 2017/11/20
- [Qemu-block] [PATCH for-2.11 3/3] block: Error out on load_vm with active dirty bitmaps, Kevin Wolf, 2017/11/20
- Re: [Qemu-block] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps, Eric Blake, 2017/11/20
- Re: [Qemu-block] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps, Denis V. Lunev, 2017/11/20
- Re: [Qemu-block] [Qemu-devel] [PATCH for-2.11 0/3] block: Error out on load_vm with active dirty bitmaps,
John Snow <=