[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 1/5] blockjob: do not allow coroutine double ent
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH 1/5] blockjob: do not allow coroutine double entry or entry-after-completion |
|
Date: |
Tue, 21 Nov 2017 13:42:09 +0100 |
|
User-agent: |
Mutt/1.9.1 (2017-09-22) |
Am 20.11.2017 um 23:25 hat Paolo Bonzini geschrieben:
> On 20/11/2017 12:16, Stefan Hajnoczi wrote:
> > This raises questions about the ability to cancel sleep:
> >
> > 1. Does something depend on cancelling sleep?
>
> block_job_cancel does, but in practice the sleep time is so small
> (smaller than SLICE_TIME, which is 100 ms) that we probably don't care.
Just note that this is something that can happen during the final
migration phase when the VM is already stopped. In other words, with
non-shared storage, these up to 100 ms are added to the migration
downtime.
Kevin
> I agree with Jeff that canceling the sleep by force-entering the
> coroutine seemed clever but is probably a very bad idea.
>
> Paolo
signature.asc
Description: PGP signature
[Qemu-block] [PATCH 2/5] coroutine: abort if we try to enter coroutine scheduled for another ctx, Jeff Cody, 2017/11/19
[Qemu-block] [PATCH 3/5] coroutines: abort if we try to enter a still-sleeping coroutine, Jeff Cody, 2017/11/19
Re: [Qemu-block] [PATCH 3/5] coroutines: abort if we try to enter a still-sleeping coroutine, Paolo Bonzini, 2017/11/20