Re: [Qemu-block] [Qemu-devel] [PATCH 01/17] block/vmdk: Fix , instead of ; at end of line

[Eric Blake]

On 11/22/2017 08:08 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz <address@hidden>
> ---
>   block/vmdk.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

No semantic difference as far as I can tell, but avoiding needless use 
of the comma operator is always a win in my book.

Reviewed-by: Eric Blake <address@hidden>

> diff --git a/block/vmdk.c b/block/vmdk.c
> index c665bcc977..1ae47b1c2e 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -1398,7 +1398,7 @@ static int vmdk_write_extent(VmdkExtent *extent, int64_t 
> cluster_offset,
>           qemu_iovec_concat(&local_qiov, qiov, qiov_offset, n_bytes);
>       }
>   
> -    write_offset = cluster_offset + offset_in_cluster,
> +    write_offset = cluster_offset + offset_in_cluster;
>       ret = bdrv_co_pwritev(extent->file, write_offset, n_bytes,
>                             &local_qiov, 0);
>   

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org