Re: [Qemu-block] [Qemu-devel] [PATCH v4 19/20] vvfat: Switch to .bdrv_co_block_status()

[Eric Blake]

On 11/30/2017 06:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> 12.10.2017 21:59, Eric Blake wrote:
> > We are gradually moving away from sector-based interfaces, towards
> > byte-based.  Update the vvfat driver accordingly.  Note that we
> > can rely on the block driver having already clamped limits to our
> > block size, and simplify accordingly.
> >
> > Signed-off-by: Eric Blake <address@hidden>
>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>

> > vvfat_co_get_block_status(BlockDriverState *bs,
> > -        int64_t sector_num, int nb_sectors, int *n, BlockDriverState 
> > **file)
> > +static int coroutine_fn vvfat_co_block_status(BlockDriverState *bs,
> > +                                              bool want_zero, int64_t 
> > offset,
> > +                                              int64_t bytes, int64_t *n,
>
> may be rename to *pnum ?

I don't see it making a difference; it would match the callback 
definition more closely, but the code is short enough that it's not that 
confusing with keeping the naming as-is.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org