Re: [Qemu-block] [Qemu-devel] [PATCH 2/2] qcow2: fix indentation after previous patch

[Eric Blake]

On 11/30/2017 10:47 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>   block/qcow2.h | 34 +++++++++++++++++-----------------
>   block/qcow2.c | 16 ++++++++--------
>   2 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/block/qcow2.h b/block/qcow2.h
> index 8f226a3609..896ad08e5b 100644
> --- a/block/qcow2.h
> +++ b/block/qcow2.h
> @@ -399,29 +399,29 @@ typedef enum QCow2ClusterType {
>   } QCow2ClusterType;
>   
>   typedef enum QCow2MetadataOverlap {
> -    QCOW2_OL_MAIN_HEADER_BITNR    = 0,
> -    QCOW2_OL_ACTIVE_L1_BITNR      = 1,
> -    QCOW2_OL_ACTIVE_L2_BITNR      = 2,
> -    QCOW2_OL_REFCOUNT_TABLE_BITNR = 3,
> -    QCOW2_OL_REFCOUNT_BLOCK_BITNR = 4,
> -    QCOW2_OL_SNAPSHOT_TABLE_BITNR = 5,
> -    QCOW2_OL_INACTIVE_L1_BITNR    = 6,
> -    QCOW2_OL_INACTIVE_L2_BITNR    = 7,
> +    QCOW2_OL_MAIN_HEADER_BITNR      = 0,
> +    QCOW2_OL_ACTIVE_L1_BITNR        = 1,

This demonstrates why I'm a fan of single space before =:
    foo = 1,
    blah = 2,
because it is needless churn to realign everything if you add a new 
longer line that doesn't fit with the earlier alignment of =.  But we 
don't have a clear preference for either code style, and I'm also okay 
if you just squash this in with the previous patch or omit it altogether.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org