Re: [Qemu-block] [PATCH 03/10] qemu-iotests: be strict with expected output

[Max Reitz]

On 2017-11-16 18:38, Cleber Rosa wrote:
> The contract between runner (check) and test is one that accepts some
> minor differences in the expcted output, as the comparison method
> employed is a "diff -w".
> 
> This is an exception to a clearer and more straightforward rule of
> just requiring the generated output to be *equal* (and not similar) to
> the recorded expected output.
> 
> Let's drop this exception and make things more predictable.

But this has been a conscious choice, as your very patch shows.
checkpatch yields 48 trailing whitespace errors, which is exactly what
the -w is for.

Also, I can't apply it because the 061.out hunks have been line-wrapped
by the \r for some reason.

Max

> 
> Signed-off-by: Cleber Rosa <address@hidden>
> ---
>  tests/qemu-iotests/026.out | 92 
> +++++++++++++++++++++++-----------------------
>  tests/qemu-iotests/049.out |  4 +-
>  tests/qemu-iotests/061.out |  4 +-
>  tests/qemu-iotests/104.out |  2 +-
>  tests/qemu-iotests/109.out | 44 +++++++++++-----------
>  tests/qemu-iotests/175.out |  2 +-
>  tests/qemu-iotests/check   |  4 +-
>  7 files changed, 76 insertions(+), 76 deletions(-)

signature.asc
Description: OpenPGP digital signature